Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Add Lower case mapping definition in 6.1 #577

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Normative: Add Lower case mapping definition in 6.1 #577

merged 1 commit into from
Jul 22, 2021

Conversation

FrankYFTang
Copy link
Contributor

Address #576

@FrankYFTang FrankYFTang requested a review from ljharb June 2, 2021 18:48
ljharb
ljharb approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me

@leobalter leobalter changed the title Add Lower case mapping definition in 6.1 Normative: Add Lower case mapping definition in 6.1 Jun 3, 2021
@sffc
Copy link
Contributor

sffc commented Jun 3, 2021 •
edited
Loading

2021-06-03 TG2 consensus: https://github.com/tc39/ecma402/blob/master/meetings/notes-2021-06-03.md#normative-add-lower-case-mapping-definition-in-61

Note that we should still seek TG1 consensus at the next TC39 meeting.

ryzokuken
ryzokuken approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, this is normative but doesn't change web reality, right? It's just specifying currently unspecified things? (uppercase to lowercase conversion)

@FrankYFTang
Copy link
Contributor Author

IIUC, this is normative but doesn't change web reality, right? It's just specifying currently unspecified things? (uppercase to lowercase conversion)

yes, that is the case.

@FrankYFTang
Copy link
Contributor Author

@ryzokuken - I saw you assign this to me, could you please explicitly tell me what you expect me to do for this PR now? I am not sure what is the expectation. Thanks

@ryzokuken
Copy link
Member

ryzokuken commented Jul 12, 2021 •
edited
Loading

well, I didn't mean it in a way that you need to do something for this one right now, just that you're assigned to the overall PR. I will present this PR to TG-1 tomorrow after which we should be able to merge this :D

@ryzokuken
Copy link
Member

2021-07-13: TG1 consensus at the July TC39 meeting.

Merging this because it has TG1 and TG2 consensus and multiple positive reviews.

@ryzokuken ryzokuken merged commit cda8a37 into master Jul 22, 2021
@ryzokuken ryzokuken deleted the FrankYFTang-patch-2 branch July 22, 2021 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@leobalter leobalter leobalter approved these changes

@sffc sffc sffc approved these changes

@ryzokuken ryzokuken ryzokuken approved these changes

@anba anba Awaiting requested review from anba

@gibson042 gibson042 Awaiting requested review from gibson042

Assignees

@FrankYFTang FrankYFTang

Labels
normative
Projects
ECMA-402 Meeting Topics
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@FrankYFTang @sffc @ryzokuken @ljharb @leobalter @gibson042 @anba